Skip to content

Completed Competitive coding 2#1151

Open
manavahlawat18 wants to merge 1 commit intosuper30admin:masterfrom
manavahlawat18:master
Open

Completed Competitive coding 2#1151
manavahlawat18 wants to merge 1 commit intosuper30admin:masterfrom
manavahlawat18:master

Conversation

@manavahlawat18
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Both solutions are correct and efficient, demonstrating a good understanding of the problems.
    • The use of HashMap in Problem1.java is a clever optimization over the brute-force approach.
    • The DP approach in Problem2.java is well-implemented and follows the standard solution pattern.
  • Areas for Improvement:
    • In Problem2.java, consider using more descriptive variable names to enhance readability.
    • For Problem2.java, you could mention the possibility of optimizing space complexity further, though it might not be necessary for all cases.
    • The comments in Problem1.java are helpful, but adding a brief description of the method's purpose at the top would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants