Skip to content

Conversation

@Amaan-29
Copy link

No description provided.

@super30admin
Copy link
Owner

For MergeSortedArrays.java:

  • Strengths: Correct implementation of the two-pointer approach, good variable naming, and proper indentation.
  • Areas for improvement: The solution is incomplete as it doesn't handle the case where there are remaining elements in nums2 after the main loop. Add a final loop to copy these elements to nums1.

For RemoveDuplicates.java:

  • Strengths: Correct implementation, optimal time and space complexity, clean code.
  • Areas for improvement: Consider adding comments to explain the logic, especially the condition if(i<2 || n!=nums[i-2]).

Overall, the student demonstrates good understanding of the two-pointer technique but needs to ensure all edge cases are handled in the solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants