SD-1032 - fix(comments): fix threading for round trip google docs comments [stable] #1409
Conversation
harbournick
changed the title
|
don't merge pending manual QA fyi @missysuperdoc |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const values = comment.getValues(); | ||
| const richText = values.commentText; | ||
| const schema = convertHtmlToSchema(richText); | ||
| // Prefer the original DOCX comment JSON captured at import time (Word/Google Docs), | ||
| // otherwise rebuild from the stored rich-text HTML. | ||
| const schema = values.docxCommentJSON || convertHtmlToSchema(richText); |
There was a problem hiding this comment.
The new export path prefers docxCommentJSON over the current commentText, but docxCommentJSON is only captured once when the comment is created from a DOCX/Google Docs import and is never updated when the user edits the comment (see use-comment.js). As a result, any imported comment that is modified in the app will be re-exported with its original content, silently discarding the user’s edits on round trips.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
From what I can tell, this did export new comments attached to the original imported threads:
|
@harbournick I did test this and this branch is able to import Google Docs threads to SD, then export docx. When importing the docx back to Google Docs, the comments remain threaded 👍 |
chittolinag
changed the title
…s multiple strategies
…d changes in Google Docs
|
@missysuperdoc this should be ready to test again. |
No description provided.