fix(comments): create dynamic comment export system based on document origin type #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added permStart/permEnd translators and schema * chore: removed logs * feat: allow editing sections with permStart/permEnd * feat: added highlight for permStart/permEnd * fix: show permStart/permEnd highlights in other document modes * fix: edge cases * refactor: removed unused class * refactor: removed unused code * fix: overlay styles * refactor: removed unused code * chore: change permission island background color * feat: allow users in permStart/permEnd * fix: infinite loop * chore: small code tweaks * chore: added docs * chore: added docs * refactor: rename functions * chore: rename test * chore: simplified code * fix: tests * fix: tests * chore: removed unused fns
…xport functionality
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8337c9e315
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...super-editor/src/core/super-converter/v3/handlers/w/commentRange/comment-range-translator.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
What
Why
suggestions. Without this, comments appear as normal highlights instead of threaded tracked‑change comments.
How
trackDelete marks.