Skip to content

Revert "Update utils.py" #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pacuraro merged 1 commit into from
Oct 7, 2025
Merged

Revert "Update utils.py" #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notifications/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.1.1"
__version__ = "0.1.0"
2 changes: 0 additions & 2 deletions notifications/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ def notify(
template=None,
context=None,
create_link=False,
unfurl_links=False,
additional_email_targets=None,
attachments: Optional[list[Attachment]] = None,
slack_attachments=None,
Expand All @@ -138,7 +137,6 @@ def notify(

slack_text = f'{subject}: {message}' if subject else message
api_kwargs = event.slack_api_kwargs()
api_kwargs["unfurl_links"] = unfurl_links
if slack_attachments:
# TODO: can this be taken from a more "generic" arg and also use it in email?
api_kwargs['attachments'] = slack_attachments
Expand Down
4 changes: 2 additions & 2 deletions testapp/tests/test_blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_templated(self):
channel='@someone',
icon_emoji=':something:',
text='dull version',
unfurl_links=False,
unfurl_links=0,
username='NotTestBot',
),
)
Expand Down Expand Up @@ -128,7 +128,7 @@ def test_message_blocks(self):
self.sc_mock.return_value.chat_postMessage.assert_called_once_with(
text='*Fruits in bag:* 1\napple\n*Cars in garage:* 2\nfiat\ntesla',
channel='@someone',
unfurl_links=False,
unfurl_links=0,
username='NotTestBot',
as_user=0,
icon_emoji=':something:',
Expand Down