Remove null=True for DNSDomain and DNSRecords#133
Closed
Conversation
gsilvapt
approved these changes
Jun 28, 2023
Contributor
gsilvapt
left a comment
There was a problem hiding this comment.
I'm in favour of removing these attributes in both models, they are not appropriate for their data types.
When releasing this, we might need to add a note for all forks take into account this change (they will need to provide a default, most likely).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 77.25% 77.27% +0.02%
==========================================
Files 84 85 +1
Lines 4022 4026 +4
==========================================
+ Hits 3107 3111 +4
Misses 915 915 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d5fc01f to
f994e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns_ips slack module assumes domains and records cannot be null so it tries to strip them here: https://github.com/surface-security/surface/blob/main/surface/dns_ips/slack.py#L74-83
We should either remove null=True to avoid this issue or filter for that in the slack processor.
I think removing null=True from these model fields makes sense as I do not think we have any need for records/domains without a name.