set initial loading state from options fields#341
Merged
TGlide merged 2 commits intosvecosystem:mainfrom Dec 20, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: f9f7d36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently i ran into an issue with displaying a table with resource data. I do basic flow in markup like:
{#if someResource.loading}...{:else if someResource.error}...{:else}<!-- working with resource data -->{/if}. And when i try to display date like<td>{formatter.format(someResource.current!.user.created_at)}</td>, i get an error saying that i am trying to display data that is undefined. After some time of debugging i found line with loading definition that is justlet loading = $state(false). So this is the reason i got that error. It first tries to render block that i assume has a valid data, then starts handling loaderFn. I think it would be nice to set initial loading state that depends on params (check whether params have initial data or not + check "lazy" field).