Refactoring data handler

[Mosch0512]

This pull request significantly refactors the core data handling logic within the project, moving from specialized, macro-heavy implementations to a more generic, template-based, and metadata-driven architecture. The changes aim to improve code reusability, maintainability, and clarity across different data types, particularly for item and skill management, by centralizing common operations like file I/O, saving, and change tracking.

Highlights

• Generic Data Handling Framework: Introduced a new generic CommonDataSaver class and DataFileIO namespace to centralize file I/O, encryption/decryption, checksum verification, and backup creation for various data types.
• Metadata-Driven Change Tracking: Implemented a FieldMetadata system that replaces error-prone X-macros with C++20 constexpr arrays for defining struct fields. This enables generic, readable, and maintainable comparison logic for data changes, as demonstrated with ItemComparisonMetadata and SkillComparisonMetadata.
• Refactored Item and Skill Data Logic: The ItemDataSaver, ItemDataLoader, SkillDataSaver, and SkillDataLoader classes have been refactored to utilize the new generic CommonDataSaver and DataFileIO components, significantly reducing code duplication and improving maintainability.
• File Renames and Structure Updates: Several files related to item and skill data handling have been renamed for clarity and consistency (e.g., ItemDataFileIO.cpp to DataFileIO.cpp, ItemDataExporter.h to ItemDataExportAsCSV.h). The TRANSLATION_SYSTEM_INTEGRATION.md documentation was updated to reflect new file paths.

[gemini-code-assist]

Summary of Changes

Hello @Mosch0512, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring of the project's data handling mechanisms. The primary goal is to enhance code reusability and maintainability by transitioning from specialized, macro-heavy implementations to a more generic, template-based, and metadata-driven architecture. This change centralizes common operations like file I/O, data saving, and change tracking, particularly for item and skill management, making the system more robust and easier to extend.

Highlights

• Generic Data Handling Framework: Introduced a new generic CommonDataSaver class and DataFileIO namespace to centralize file I/O, encryption/decryption, checksum verification, and backup creation for various data types.
• Metadata-Driven Change Tracking: Implemented a FieldMetadata system that replaces error-prone X-macros with C++20 constexpr arrays for defining struct fields. This enables generic, readable, and maintainable comparison logic for data changes, as demonstrated with ItemComparisonMetadata and SkillComparisonMetadata.
• Refactored Item and Skill Data Logic: The ItemDataSaver, ItemDataLoader, SkillDataSaver, and SkillDataLoader classes have been refactored to utilize the new generic CommonDataSaver and DataFileIO components, significantly reducing code duplication and improving maintainability.
• File Renames and Structure Updates: Several files related to item and skill data handling have been renamed for clarity and consistency (e.g., ItemDataFileIO.cpp to DataFileIO.cpp, ItemDataExporter.h to ItemDataExportAsCSV.h). The TRANSLATION_SYSTEM_INTEGRATION.md documentation was updated to reflect new file paths.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly refactors the core data handling logic, moving from specialized, macro-heavy implementations to a more generic, template-based, and metadata-driven architecture. Key improvements include the introduction of CommonDataSaver and DataFileIO for centralized I/O, a FieldMetadata system for generic change tracking, and refactored item and skill data logic to leverage these new components. File renames and documentation updates reflect these structural changes, enhancing code reusability, maintainability, and clarity.