Sound not working

[Mosch0512]

Fixed sound now its working
This branch includes the sound files and the fix

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[nitoygo]

I think the sound folder is too big to be included in the repo.
Maybe good to add a separate build step that downloads the files from somewhere.
And copyright issues may also need to be considered

[sven-n]

Please remove the last commit (with force 😅), because that's 200 MB of binaries. Git is very bad at handling this, and once they're in the history, you can't get rid of them anymore.

[Mosch0512]

okidoki

[Mosch0512]

I think i found some duplicated logic that i have missed let me check that first 🗡️

[gemini-code-assist]

Summary of Changes

Hello @Mosch0512, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where sound was not functioning correctly by implementing a significant refactoring of the sound volume management system. The changes introduce a new internal method to handle the intricacies of setting volume, which helps to standardize how volume is applied to sound buffers, thereby resolving the reported sound problems and improving the robustness of the audio system.

Highlights

• Sound Volume Refactoring: The logic for setting sound volume has been refactored into a new private method, SetVolumeInternal, centralizing the clamping and application of volume to individual sound buffers.
• Improved Volume Control: The SetVolume and LoadWaveFile methods now delegate to the new SetVolumeInternal method, ensuring consistent and correct application of volume settings across different sound operations.
• Code Cleanup: Unused header includes, specifically <cstddef> and "ZzzInfomation.h", have been removed, and the remaining includes have been reordered for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a potential deadlock in the DirectSoundManager by refactoring the volume-setting logic. The introduction of the private SetVolumeInternal method, which is called within a mutex lock by SetVolume and LoadWaveFile, prevents recursive locking and resolves the likely cause of the sound system hanging. The removal of unused headers is also a good cleanup. The changes are correct and improve the robustness of the sound system.