Stop debug session on prelaunchTask failures (Prevent 100% CPU) #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
Contributor
Author
|
@hyzyla this is an important fix as it severely impacts battery life and performance. (multiple debugserver processes can end up clogging the CPU) |
Contributor
Author
|
I just noticed this issue is more evident if you have VSCode setup to try attach to the debugger even if there are tasks failrues. Leaving it as a draft as it's worth more testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very often, VSCode does not always stop the debug session when a preLaunchTask fails, even if configured to do so. It may continue to start the debug server, lingering around using 100% CPU until the user manually interrupts the debug session.
What Changed
This change checks for
xcodebuildtask failures, displays a "Build failed" message, and immediately stops the debug session.How to test
debugserverprocess should not be present In Activity Monitor