Conversation
martin4861
approved these changes
Nov 3, 2025
Contributor
martin4861
left a comment
martin4861
left a comment
There was a problem hiding this comment.
lgtm, could you remove https://github.com/swift-nav/libsbp/blob/master/MODULE.bazel#L30 too?
Contributor
Author
Good catch, thanks! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are a few issues with using the
checklibrary to test the C language bindings:checkdoes not appear to be actively maintainedcheckdoes not compile with recent versions of MinGW64 (see Fix compilation using MinGW-W64 13 and later libcheck/check#364)checkonly used by libsbp; all of the other swift repos have switched over togtestThis PR converts the C language bindings to use
gtest, which means compiling the unit tests as C++ instead of C.The changes in this PR are loosely modelled on https://github.com/swift-nav/libswiftnav-private/commit/1f13a3b0e5125b3396c4d9abaf1fcddd3ffd17e2.
API compatibility
Does this change introduce a API compatibility risk?
No, it only changes test cases.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX