Skip to content

Fixes SwitcherTest when input not provided for evaluation #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petruki merged 1 commit into from
Nov 16, 2024
Merged

Fixes SwitcherTest when input not provided for evaluation #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/com/github/switcherapi/client/model/response/CriteriaResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ public class CriteriaResponse {
protected Map<String, List<String>> entryWhen;

public CriteriaResponse() {
entryWhen = new HashMap<>();
}

public CriteriaResponse(final boolean result, final String reason, final Switcher switcher) {
this();
this.result = result;
this.reason = reason;
this.switcherKey = switcher.getSwitcherKey();
Expand All @@ -58,7 +60,7 @@ public CriteriaResponse buildFromSwitcher(Switcher switcher) {
}

private boolean isEntryMatching(Entry inputEntry) {
return entryWhen.containsKey(inputEntry.getStrategy()) &&
return entryWhen.isEmpty() || entryWhen.containsKey(inputEntry.getStrategy()) &&
entryWhen.get(inputEntry.getStrategy()).contains(inputEntry.getInput());
}

Expand Down Expand Up @@ -120,10 +122,6 @@ public CriteriaResponse when(StrategyValidator strategy, String input) {
}

public CriteriaResponse when(StrategyValidator strategy, List<String> inputs) {
if (entryWhen == null) {
entryWhen = new HashMap<>();
}

entryWhen.put(strategy.toString(), inputs);
return this;
}
Expand Down