feat: move backend from demo-repository #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Domenic Dvojmoc <applecakes811@gmail.com>
Member
|
Live and possibly alive @ https://pr-2.dev.sync.si/api/ |
Member
|
this is ready for review? |
Member
Author
@MaticBabnik yes, this is more or less the foundation we will work around |
Closed
MaticBabnik
requested changes
Jan 7, 2026
backend/src/WebSocketServer.ts
Outdated
| clientID: ClientID; | ||
| } | ||
|
|
||
| export const HANDLER_REGISTRY: Record<string, (ws: Bun.ServerWebSocket<WebSocketData>, message: any) => void> = {} |
Member
There was a problem hiding this comment.
Would prefer that the REGISTRY would be constructed in one file (registry file imports all functions) rather than each handler registering itself in it's own file
Member
There was a problem hiding this comment.
why is event/clientJoin a thing? This should probably run on open
| * Returns a shallow clone of all rooms | ||
| */ | ||
| export function allRooms(): Map<string, Room> { | ||
| return new Map<string, Room>(rooms) |
Member
There was a problem hiding this comment.
Again not a fan of shallow clones.
If we really care about the map not being mutable we can just provide getRoom(x:string): Room and getRooms(): Iterator<Room> (maybe its Iterable not sure)
backend/src/index.ts
Outdated
| const app = new Elysia() | ||
| .get("/randomNumber", () => ({ result: ~~(Math.random() * 10000) })) | ||
| .get('/health', () => 'OK') | ||
| const statusler = "healthy"; |
backend/src/index.ts
Outdated
| .get("/randomNumber", () => ({ result: ~~(Math.random() * 10000) })) | ||
| .get('/health', () => 'OK') | ||
| const statusler = "healthy"; | ||
| let uptimeler = Date.now(); |
backend/src/index.ts
Outdated
| uptime: Math.floor((Date.now() - uptimeler) / 1000) | ||
| } | ||
| }) | ||
| .listen(3000); |
I'm too cool to wait around for CI
Co-authored-by: Copilot <@Copilot>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.