Include an option on handle_redirect to take a custom timeout. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuldR
force-pushed
the
add-timeout-to-handle-redirect
branch
from
1a6d533 to
e4805cd
Compare
DuldR
force-pushed
the
add-timeout-to-handle-redirect
branch
from
e4805cd to
6baf5a0
Compare
Member
|
Cool! I'm in the middle of some head-breaking code right now, but will get this reviewed and released tomorrow morning. Looks good at first glance, though! |
Member
|
Just released v4.0.0. Not that there are 3rd-party drivers, but if there were this would be a breaking change on the driver side. Whee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now allows for
handle_redirectto take a custom timeout. If nothing is provided, we default to whatPhoenix.LiveViewTest.assert_redirectalready uses(100ms) at: Phoenix.LiveViewTest.assert_redirect.With this, you can now do something like:
This should address #22