Polish bottom sheets #279
Polish bottom sheets #279
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/screens/wallets/send/QuickPaySendScreen.kt
Fixed
Show fixed
Hide fixed
Pull request was converted to draft
Refactored yet again 🙈 , probably needs new testing. |
No problem |
Feel free to review & retest, but please don't merge yet, I also want to fix the size for the boost sheet, it should use the |
|
@jvsena42 Updated the boost sheet as well, ready for review of that part and merging 🙏🏻 |
|
Testing... |
There was a problem hiding this comment.
Tested in Mi A2
The space between the text and the swipe looks too big compared to figma, probably because of the sheet height. I'm not sure if it should be fixed or adaptive with a maximum value.
This could be adjusted in another branch if necessary
There was a problem hiding this comment.
I noticed, went with choosing to make it look close to the RN version, instead of creating a separate size for this sheet.
It needed fixed sizing though, as the sheet was changing height depending on user interaction.
Can always improve later 👍🏻
This PR adds fixes and polishing for bottom sheets.
Description
Preview
sheetSizes.mp4
QA Notes
Test all sheets: