fix: NumberPad event click when disabled #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the NumberPad action button remained clickable even when disabled, by removing the click event handler when the button is in a disabled state.
- Replaced the active
onClickhandler with an empty lambda when the button is disabled
app/src/main/java/to/bitkit/ui/components/NumberPadActionButton.kt
Outdated
Show resolved
Hide resolved
ovitrif
previously approved these changes
Dec 22, 2025
auto-merge was automatically disabled
December 22, 2025 11:51
Pull request was converted to draft
Member
Author
|
drafted to replace the Secondary button component with a more simple composable |
Member
Author
Done, preview updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #534
Description
This PR removes the event click of NumberPad when disabled
Preview
splitted_invoice.webm
uniffied_invoice.webm
QA Notes