Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Dec 22, 2025

FIGMA

Description

This PR removes the terms checkbox according the v59 design

Preview

Screen_recording_20251222_093012.webm

QA Notes

  • Test navigation

@jvsena42 jvsena42 self-assigned this Dec 22, 2025
@jvsena42 jvsena42 enabled auto-merge December 22, 2025 12:32
@jvsena42 jvsena42 requested a review from ovitrif December 22, 2025 12:33
@jvsena42 jvsena42 marked this pull request as draft December 22, 2025 12:45
auto-merge was automatically disabled December 22, 2025 12:45

Pull request was converted to draft

@jvsena42
Copy link
Member Author

Drafted to update the text

@jvsena42 jvsena42 marked this pull request as ready for review December 22, 2025 12:49
@jvsena42
Copy link
Member Author

Drafted to update the text

Actually, I'll update on transaifex

@jvsena42
Copy link
Member Author

@jvsena42
Copy link
Member Author

@piotr-iohk need a update on E2E here

@piotr-iohk
Copy link
Collaborator

piotr-iohk commented Dec 22, 2025

Rerunning e2e after update: https://github.com/synonymdev/bitkit-android/actions/runs/20432413536

Note, the FIGMA also drops Slide2 (Bitcoiners, Borderless), perhaps good opportunity to address here.
If you remove Slide2 please let me know, need to update e2e for that as well. Also, note that on iOS Slide2 is removed but slide test-ids were not "re-indexed", so it is Slide0, Slide1, Slide3, Slide4... so it would be good to have it like that in Android for e2e sake and consistency.

@ovitrif
Copy link
Collaborator

ovitrif commented Dec 22, 2025

need a push here as the e2e are still showing skipped @jvsena42

@jvsena42
Copy link
Member Author

jvsena42 commented Dec 22, 2025

need a push here as the e2e are still showing skipped @jvsena42

Triggered it manually
https://github.com/synonymdev/bitkit-android/actions/runs/20432413536

@jvsena42
Copy link
Member Author

Rerunning e2e after update: https://github.com/synonymdev/bitkit-android/actions/runs/20432413536

Note, the FIGMA also drops Slide2 (Bitcoiners, Borderless), perhaps good opportunity to address here. If you remove Slide2 please let me know, need to update e2e for that as well. Also, note that on iOS Slide2 is removed but slide test-ids were not "re-indexed", so it is Slide0, Slide1, Slide3, Slide4... so it would be good to have it like that in Android for e2e sake and consistency.

Thanks! I'll do it in the next PR for android and iOS

@ovitrif
Copy link
Collaborator

ovitrif commented Dec 22, 2025

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ovitrif ovitrif merged commit 714e83b into master Dec 22, 2025
42 of 58 checks passed
@ovitrif ovitrif deleted the chore/remove-onboarding-checkbox branch December 22, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants