-
Notifications
You must be signed in to change notification settings - Fork 1
fix: lnurl navigating to the next step before ui update #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… state before navigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a race condition in the LNURL-withdraw flow where navigation occurs before the UI has time to recompose with updated state values. When an LNURL-withdraw request has equal minimum and maximum amounts, the code was immediately navigating to the confirmation screen before the UI could reflect the new state, causing the app to appear frozen or unresponsive.
Key Changes:
- Added a coroutine-based delay before navigation in the LNURL-withdraw handler
- Uses the existing
TRANSITION_SCREEN_MSconstant to ensure UI recomposition completes
|
@piotr-iohk Does this PR unblock some E2E flow? like |
|
Couldn't decode the lnurl invoices locally, but it is passing on E2E, so I suppose it is something in my setup |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes, it was like that in the RN app, therefore it was ported. I guess the idea was to go through the Qr screening flow. |
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck.
Will test later today but you can already merge.
All LGTM, if required changes are identified after testing, we can always fix later.
Closes #418
Description
The fix:
Preview
QA Notes