fix: text input was forcing the cursor to the end on every recomposition #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a cursor positioning bug in the TextInput component where the cursor was being forced to the end of the text field on every recomposition, making it impossible for users to edit text in the middle of the input.
Key Changes:
- Implemented internal state management for
TextFieldValueto preserve cursor position across recompositions - Added synchronization logic to handle external text changes while preserving cursor position when possible
- Disabled autocorrect for the Electrum server IP address input field
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
app/src/main/java/to/bitkit/ui/components/TextInput.kt |
Introduced remember state for TextFieldValue and LaunchedEffect to sync external changes while preserving cursor position |
app/src/main/java/to/bitkit/ui/settings/advanced/ElectrumConfigScreen.kt |
Disabled autocorrect for IP address input field |
jvsena42
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ovitrif
approved these changes
Jan 8, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
tAck
thanks for this fix 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #577
Description
Cause:
Every recomposition creates a NEW TextFieldValue with cursor forced to end via TextRange(value.length). This overwrites whatever cursor position the user had.
Solution:
Keep the TextField's internal state and sync external changes
Preview
Screen_recording_20260108_134224.webm
QA Notes