-
Notifications
You must be signed in to change notification settings - Fork 1
feat: sweep funds from unsupported address types #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
app/src/main/java/to/bitkit/ui/onboarding/InitializingWalletView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/MigrationLoadingScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/advanced/sweep/SweepConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/advanced/sweep/SweepFeeRateScreen.kt
Outdated
Show resolved
Hide resolved
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I'll test after the the keepScreenOn modifier implementation
app/src/main/java/to/bitkit/ui/screens/transfer/SavingsProgressScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/advanced/sweep/SweepConfirmScreen.kt
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM ✅ Testing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with:
- P2SH ✅
- P2TR ✅
This comment was marked as resolved.
This comment was marked as resolved.
|
Yes already updated to check on restore e8afb3a |
This PR adds an advanced setting option to find and sweep funds in unsupported address types (legacy, nested segwit, and taproot). On migration / restore from RN app it will run automatically in the background and if funds detected will show the user a sheet suggesting to sweep the funds.
The PR also updates the migration loading screen UI to match the Figma design.