Sweep funds from unsupported address types #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to sweep funds from unsupported Bitcoin address types (Legacy, Nested SegWit, and Taproot) into the wallet's native SegWit addresses. After migration or restoration from the RN app, the feature automatically checks for funds in these address types and prompts the user to sweep them if detected. Additionally, the PR refactors biometric authentication into a reusable utility and updates the migration loading screen UI to match the Figma design.
Key changes:
- New sweep funds feature with multi-step UI flow (check → confirm → broadcast)
- Refactored biometric authentication from duplicate code into shared
BiometricAuthutility - Updated migration loading screen with improved visual design and layout
Reviewed changes
Copilot reviewed 20 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| SendConfirmationView.swift | Refactored to use centralized BiometricAuth utility, removing duplicate authentication code |
| LnurlPayConfirm.swift | Refactored to use centralized BiometricAuth utility, removing duplicate authentication code |
| SweepSuccessView.swift | New view displaying sweep completion with confetti animation and transaction details |
| SweepSettingsView.swift | New view for checking and displaying sweepable balances from unsupported address types |
| SweepPromptSheet.swift | New sheet prompting users to sweep detected funds after migration |
| SweepFeeRateView.swift | New view for selecting transaction fee rate for sweep operations |
| SweepFeeCustomView.swift | New view for entering custom fee rates for sweep transactions |
| SweepConfirmView.swift | New view for confirming and broadcasting sweep transactions with PIN/biometric auth |
| AdvancedSettingsView.swift | Added navigation link to sweep funds feature in advanced settings |
| SweepViewModel.swift | New view model managing sweep state, balance checking, transaction preparation and broadcasting |
| SheetViewModel.swift | Added sweep prompt sheet configuration support |
| NavigationViewModel.swift | Added sweep-related navigation routes |
| AppViewModel.swift | Removed redundant migration success toast message |
| BiometricAuth.swift | New centralized utility for biometric authentication with Face ID/Touch ID |
| MigrationsService.swift | Changed isRestoringFromRNRemoteBackup to @published for reactive updates |
| Localizable.strings | Added localization strings for sweep feature and migration screen |
| MainNavView.swift | Added sweep view destinations and injected SweepViewModel into navigation |
| magnifying-glass-illustration.imageset | Added new illustration asset for sweep loading state |
| AppScene.swift | Integrated sweep funds check after migration/restore and updated migration loading UI |
| Package.resolved | Updated bitkit-core dependency to support sweep functionality |
jvsena42
reviewed
Jan 8, 2026
jvsena42
reviewed
Jan 9, 2026
Member
|
LGTM, just have this question Please, close the solved comments Will approve it after testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an advanced setting option to find and sweep funds in unsupported address types (legacy, nested segwit, and taproot). On migration / restore from RN app it will run automatically in the background and if funds detected will show the user a sheet suggesting to sweep the funds.
The PR also updates the migration loading screen UI to match the Figma design.
Simulator.Screen.Recording.-.iPhone.16.-.2026-01-07.at.20.29.15.mp4