feat: add QuickPay #2357
Merged
feat: add QuickPay #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
feat/quickpay
branch
2 times, most recently
from
43ccfcf to
c4be1e2
Compare
limpbrains
suggested changes
Nov 25, 2024
Contributor
limpbrains
left a comment
limpbrains
left a comment
There was a problem hiding this comment.
It behaves strangely when I'm trying to pay for invoice that fails
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-25.at.12.33.12.mp4
Collaborator
Author
Fixed by using |
limpbrains
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add QuickPay: settings screen and scanner logic
Linked Issues/Tasks
Closes #2058
Type of change
Tests
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-22.at.17.45.09.mp4
QA Notes
Make sure QuickPay threshold is respected. It should only work for unified and lightning invoices with an amount.