Use readline on the input fd instead of iterating#5
Open
sigmaris wants to merge 1 commit intosystemd:masterfrom
Open
Use readline on the input fd instead of iterating#5sigmaris wants to merge 1 commit intosystemd:masterfrom
sigmaris wants to merge 1 commit intosystemd:masterfrom
Conversation
In Python 2.x, using 'for line in self.fd' causes messages to be delayed and arrive in bursts due to internal read-ahead buffering, see http://bugs.python.org/issue3907 Using readline() explicitly avoids this problem as it doesn't read ahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 2.x, using 'for line in self.fd' causes messages to be delayed and arrive in bursts due to internal read-ahead buffering, see http://bugs.python.org/issue3907 and http://stackoverflow.com/questions/2804543/read-subprocess-stdout-line-by-line
Using readline() explicitly avoids this problem as it doesn't read ahead.