[FEATURE] Enable Mobile Navigation to bottom#525
Open
vhusaruk92 wants to merge 18 commits intot3kit:masterfrom
Open
[FEATURE] Enable Mobile Navigation to bottom#525vhusaruk92 wants to merge 18 commits intot3kit:masterfrom
vhusaruk92 wants to merge 18 commits intot3kit:masterfrom
Conversation
vhusaruk92
force-pushed
the
mobile_navigation_bottom_right
branch
from
a53e13a to
901d797
Compare
Contributor
Author
|
UPD: Move the mobile button to the bottom of the page |
Contributor
Author
|
When we apply Also if apply Mobile Navigation Toggle Btn = right, it doesn't change the position of items and it dropdown is cropped too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request contains new constant - themes.configuration.menu.main.mobileNavigationToBottom whicj calls "Enable Mobile Navigation to bottom". By default it equal to 0.
The constant makes mobile navigation be placed to the bottom of the screen on mobile and tablet (max-width: @screen-sm-max).
As we need additional space at the bottom of the page - I choose to add an additional class to the footer, as footer is used in all our layouts, accept Empty one.