Tighten implementation of SnippetTiebreaker
#531
Merged
+35
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparator could return a premature result if one Snippet or both being compared has a null implementor name, resulting in an output ordering that could depend on the sequence of comparisons performed. The case is unlikely to be seen in practice, as an implementor name can only be made null by explicit implementor="" in an annotation or -Addr.implementor=- when invoking the Java compiler. Nonetheless, the tiebreaker method can be made more simple and convincing by taking advantage of the Java 8 additions to Comparator. Addresses #527. For consistency's sake, also Comparator-ize TypeTiebreaker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparator could return a premature result if one
Snippetor both being compared has a null implementor name, resulting in an output ordering that could depend on the sequence of comparisons performed. While it would still reflect the dependency graph and thus work, it would frustrate reproducible-build expectations.The case is unlikely to be seen in practice, as an implementor name can only be made null by explicit
implementor=""in an annotation or‑Addr.implementor=-when invoking the Java compiler.Nonetheless, the tiebreaker method can be made more simple and convincing by taking advantage of the Java 8 additions to
Comparator.Addresses #527.
For consistency's sake, also
Comparator-izeTypeTiebreaker.