Skip to content

menu.go: ensure that owner-draw/bitmap separators are flagged as such #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dblohm7 merged 1 commit into from
Oct 16, 2025
Merged

menu.go: ensure that owner-draw/bitmap separators are flagged as such #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions menu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,15 @@ func (m *Menu) initMenuItemInfoFromAction(mii *win.MENUITEMINFO, action *Action)
if bmp, err := iconCache.Bitmap(action.image, dpi); err == nil {
mii.HbmpItem = bmp.hBmp
}
case action.IsSeparator():
default:
}

// Being a separator is not mutually-exclusive to being an image or
// owner-draw item, so we must perform this check separately from the
// switch above.
if action.IsSeparator() {
mii.FType |= win.MFT_SEPARATOR
setString = false
default:
}

if setString {
Expand Down