Skip to content

fix(circleci-orbs+docker): latest tag bash typo missing space#232

Merged
eddiedialpad merged 1 commit intomasterfrom
kelly/docker-fix-latest-tag
Oct 30, 2025
Merged

fix(circleci-orbs+docker): latest tag bash typo missing space#232
eddiedialpad merged 1 commit intomasterfrom
kelly/docker-fix-latest-tag

Conversation

@eddiedialpad
Copy link
Contributor

Summary

syntax error prevents :latest from being tagged — we still guard and ensure that only main or master branch gets this tag, but the syntax error means no one got tagged — looks like it was broken for about two months

Custom Checklist Items

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@eddiedialpad eddiedialpad requested review from a team, TheKevJames and cphoward as code owners October 30, 2025 15:41
@eddiedialpad eddiedialpad requested review from aherrada-dialpad, shaundialpad and tonydialpad and removed request for a team October 30, 2025 15:41
@gemini-code-assist
Copy link

Summary of Changes

Hello @eddiedialpad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical syntax error in the CircleCI orb configuration that prevented Docker images from being correctly tagged with :latest. A missing space in a bash conditional statement within the docker/orb.yaml file had inadvertently disabled the latest tag for images built from the main or master branches for the past two months. The change is a small but impactful correction, restoring the intended behavior for image lifecycle management.

Highlights

  • Fix Bash Syntax Error: Corrected a missing space in a bash if condition within the CircleCI orb configuration, which was preventing the :latest Docker image tag from being applied.
  • Restore Latest Tagging: This fix ensures that Docker images built from the main or master branches are correctly tagged with :latest again, resolving an issue that had been present for approximately two months.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bash syntax error that was preventing the :latest docker tag from being applied on main or master branches. While the fix is correct, I've also suggested a refactoring to improve the orb's maintainability by using CircleCI's native conditional logic instead of a shell script, which also removes some code duplication.

@eddiedialpad eddiedialpad merged commit c2881b8 into master Oct 30, 2025
13 checks passed
@eddiedialpad eddiedialpad deleted the kelly/docker-fix-latest-tag branch October 30, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants