fix(storage): fix default scope for metadata patches

[TheKevJames]

Summary

Ensure default scope can include running patch_metadata commands. Note:
this is not a security issue, since the permissions are still limited
down to the subset granted on the SA in use.

Fixes #928

[gemini-code-assist]

Summary of Changes

Hello @TheKevJames, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue preventing metadata patching operations by adjusting the default API scope for Google Cloud Storage. The change ensures that applications can properly modify object metadata, and it's explicitly noted that this modification does not introduce new security risks, as the effective permissions are still governed by the service account's granted roles.

Highlights

• Default Storage Scope: The default Google Cloud Storage API scope has been updated from "devstorage.read_write" to "devstorage.full_control". This change is necessary to enable the successful execution of patch_metadata commands, which previously failed due to insufficient permissions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the default authentication scope for the Storage client to devstorage.full_control to support metadata patching. While this fixes the issue for patch_metadata, it increases the default permissions for all use cases. My review includes a comment suggesting an alternative approach that favors the principle of least privilege, by keeping the more restrictive default scope and requiring users to opt-in for wider permissions when needed.