Skip to content

Removed code duplication for Register in IoC #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yildizseli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed code duplication for Register in IoC #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions CommandCore.LightIoC/BasicServiceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,7 @@ private readonly ConcurrentDictionary<Type, object>
/// <exception cref="InvalidOperationException">If the concrete type is not instantiable. For instance, using an abstract class for the concrete type throws this exception.</exception>
public void Register<S, T>()
{
if (typeof(T).IsAbstract)
{
throw new InvalidOperationException(
$"Type {typeof(T).FullName} may not be abstract. Abstract classes cannot be instantiated, hence not allowed to be registered.");
}

if (!typeof(S).IsAssignableFrom(typeof(T)))
{
throw new InvalidOperationException(
$"Type {typeof(T).FullName} is not assignable to {typeof(S).FullName}");
}

_typeRegistry[typeof(S)] = typeof(T);
Register(typeof(S), typeof(T));
}

public void Register(Type service, Type implementation)
Expand Down