nohide flag in screenkey to allow the option of keeping the key screen persistant after timeout.#12
Open
davidlowryduda wants to merge 2 commits intotckmn:masterfrom
Open
nohide flag in screenkey to allow the option of keeping the key screen persistant after timeout.#12davidlowryduda wants to merge 2 commits intotckmn:masterfrom
davidlowryduda wants to merge 2 commits intotckmn:masterfrom
Conversation
…er timeout. Useful for tiling window managers.
Author
|
I should also note that I must have a setting which removes some trailing whitespace in python, and many of the changes in the diff are simply a trailing white character being removed. I hope you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I read #5 and I liked the idea of having the option to make the screenkey screen not automatically hide. I use a tiling window manager (Xmonad) by default, and this enables me to use (a small variant of) mkcast there instead of flipping to GNOME.
This causes no changes on behalf of the user at the moment. On the other hand, the functionality is not viewable at the moment either. I'm only partially proficient at bash scripting (embarrasing to say), and I'm not sure of the best way to take a flag given to mkcast or newcast and to pass it to screenkey. But this should be easy. I foresee the ability to type
newcast -nand have the-nflag ultimately passed to screenkey "nohide".