Added channel info (i.e. [25.1]) to the filename.

[jschwalbe]

Channel info to help with sorting or automated commercial removal tools (i.e. comskip)

[tdickman]

Thanks for sending this over, I appreciate the help! You're using ".encode('utf-8')" on parts of the string, but not on others. Any specific reason?

[jschwalbe]

It was that way when I started, and was afraid to get rid of it. :)

I can’t recall but I think that I tried removing it and it caused a problem.. but then I moved on to other stuff, so can’t recall exactly. Probably could go!

On Tue 8/12/14, at 9:53 PM, tdickman notifications@github.com wrote:

Thanks for sending this over, I appreciate the help! You're using ".encode('utf-8')" on parts of the string, but not on others. Any specific reason?

—
Reply to this email directly or view it on GitHub.

[tdickman]

I can take a look at it again later, and see if there is a better way, but I recommend getting rid of it.

Also, I went through and cleaned up some of the code to fall better in line with python coding standards (to keep everything consistent). A few comments:

1. Modify your editor to use 4 spaces instead of tabs
2. You typically shouldn't comment out code - just delete it since the old version will stay in the git repo for you to look at. It makes the code look a lot cleaner, and it's much easier to read.
3. Use function and variable names like this: count_the_stars() instead of: countTheStars.

It probably looks like I made a ton of changes to your code, but I mainly changed tabs to spaces, etc. It looks like all of the lines changed since I swapped tabs to spaces. No hard feelings, I know you said you are new to python coding - I'm not trying to be difficult, just trying to keep all of the files consistent :).

[jschwalbe]

No problem. It looks good! Thanks for the pointers ;)

Question — did the channel info in the filename get deleted on purpose? If so I’m just going to fork the project and keep it forked because it’s something I’m going to be relying upon with my automation.

On Tue 8/12/14, at 10:37 PM, tdickman notifications@github.com wrote:

I can take a look at it again later, and see if there is a better way, but I recommend getting rid of it.

Also, I went through and cleaned up some of the code to fall better in line with python coding standards (to keep everything consistent). A few comments:

1. Modify your editor to use 4 spaces instead of tabs
2. You typically shouldn't comment out code - just delete it since the old version will stay in the git repo for you to look at. It makes the code look a lot cleaner, and it's much easier to read.
3. Use function and variable names like this: count_the_stars() instead of: countTheStars.

It probably looks like I made a ton of changes to your code, but I mainly changed tabs to spaces, etc. It looks like all of the lines changed since I swapped tabs to spaces. No hard feelings, I know you said you are new to python coding - I'm not trying to be difficult, just trying to keep all of the files consistent :).

—
Reply to this email directly or view it on GitHub.

[tdickman]

Nope, that was a mistake - if you can make update you branch (with the newest changes), and send another pull request, I can merge it back in. Sorry about that!