Open
Conversation
Queue-ri
reviewed
Sep 27, 2023
| public void checkKeyword() throws Exception { | ||
|
|
||
| //given | ||
| NaverNewsService.naverNewsApi(); |
Member
There was a problem hiding this comment.
이 라인이 추가된 것에 대해서 설명해주실 수 있나요?
롤백 기능이 추가된 것과 연관이 있는지요
Contributor
Author
There was a problem hiding this comment.
기존 테스트 코드에서는 @transactional을 하면 keywordTest에서 batch된 뉴스를 조회할 수 없어 keywordTest에서 실패가 자꾸 떴었습니다!
@transactional 레퍼런스를 찾아보다가 테스트 간의 격리성을 보장하기 위해 사용된다는 것을 알게되어 keywordTest에서도 NaverNewsApi를 사용하는 것으로 코드 수정 진행했습니다.
chaeeun-Han
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test DB 분리 코드 및 application.yml 작성