Use tags to assign responses to result list#92
Open
zack13532 wants to merge 2 commits into12-01-remove_usage_of_parallelstream_in_favor_of_streamfrom
Open
Conversation
This was referenced Dec 2, 2024
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 2, 2024
bcfe62e to
30bf7c0
Compare
41ee71b to
4cbb04c
Compare
This was referenced Dec 3, 2024
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously, when asynchronously processing responses for a GetFeaturesBatch request (resulting in many individual GetFeature calls), we searched for the request object in the original request list to determine where to place the response in the response list, so as to maintain ordering. This is less efficient than it could be, because it is a linear search on an ArrayList using the Request object's equals method.
Instead, use the OkHttp tags feature for Calls to store the index as metadata that can be retrieved during response processing, so we can use that directly rather than doing a search.