Optimize and reduce storage and some iterations #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danflo27
reviewed
Feb 10, 2026
Contributor
There was a problem hiding this comment.
what do you think of adding that same LastValSetUpdateHeight.Set to the BeforeValidatorSlashed hook as well ? So that it recalculates if a delegation is slashed ?
Contributor
Author
There was a problem hiding this comment.
yeah definitely should nice catch
danflo27
approved these changes
Feb 10, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
* clear old reports from storage * Fix tests * Reduce the iteration that happens when recaculating stake during submitValue * Add tests plus change some reporter cache logic * add err handler * fix edit location for config.toml timeout_commit default value * Add upgrade handler * upgrade handler for v6.1.2 * error handling, msg validation * fix test and default commit timeout setting * Trigger global stake recalc on validator slashing; fix RemoveSelector missing recalc flag --------- Co-authored-by: danflo27 <florentinodc@outlook.com> (cherry picked from commit ed5cd57)
brendaloya
pushed a commit
that referenced
this pull request
Feb 10, 2026
* clear old reports from storage * Fix tests * Reduce the iteration that happens when recaculating stake during submitValue * Add tests plus change some reporter cache logic * add err handler * fix edit location for config.toml timeout_commit default value * Add upgrade handler * upgrade handler for v6.1.2 * error handling, msg validation * fix test and default commit timeout setting * Trigger global stake recalc on validator slashing; fix RemoveSelector missing recalc flag --------- (cherry picked from commit ed5cd57) Co-authored-by: akrem <71235284+akremstudy@users.noreply.github.com> Co-authored-by: danflo27 <florentinodc@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #
Type of Change
Testing
Checklist