Go: Note that workers should run in dedicated terminal instances#4216
Draft
yuandrew wants to merge 1 commit intotemporalio:mainfrom
Draft
Go: Note that workers should run in dedicated terminal instances#4216yuandrew wants to merge 1 commit intotemporalio:mainfrom
yuandrew wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
@yuandrew is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make a note that workers should run in dedicated terminal instances. This was something I remember I misunderstood when I first learned about Temporal. Probably worth having this in the
Core applicationsection of the docs. I'm also not 100% if other SDKs have this same flow, but also probably worth porting this to other SDKs that share this requirement.Notes to reviewers
┆Attachments: EDU-5920 Go: Note that workers should run in dedicated terminal instances