Add sample showing AWS encryption SDK #700
Merged
+294
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
requested review from
a team,
antmendoza and
tsurdilo
as code owners
cretz
reviewed
Nov 4, 2024
| private Payload encodePayload(Payload payload) { | ||
| byte[] plaintext = payload.toByteArray(); | ||
| byte[] ciphertext = | ||
| crypto.encryptData(kmsKeyring, plaintext, getEncryptionContext()).getResult(); |
Member
There was a problem hiding this comment.
Is this call potentially slow (i.e. meaning ever makes a network call, even once lazily)? Should the deadlock detector be disabled or is it already disabled?
Contributor
Author
There was a problem hiding this comment.
Yeah good point, I added a line to disable the deadlock detector.
cretz
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample showing how a user could use the AWS encryption SDK to encrypt payloads with AWS KMS