feat: add custom message type filtering to hook system (Phase 3.1, Task Group 3)#7
Merged
terraboops merged 1 commit intomainfrom Feb 2, 2026
Conversation
… Group 3) - Add custom_message_type field to HookFilter struct - Implement extract_custom_message_type() for namespace detection - Update matches_filter() to check custom types against expected types - Add unit tests for custom type extraction and filtering (6 new tests) - Add integration test for E2E custom type routing - Fix clippy warnings in existing filter tests Phase 3 Task Group 3 complete. Hook system now supports filtering on all 12 custom XEP message types (thought, tool_call, tool_result, todo, code_change, integration, review_comment, work_available, question, answer, status_update, feature_complete) defined in Phase 3.1. Test Results: - 20 unit tests pass (chattermax-server) - 1 integration test passes - 15 chattermax-core tests pass - Zero compiler warnings - Clippy passes with -D warnings - Code formatted with cargo fmt
terraboops
added a commit
that referenced
this pull request
Feb 3, 2026
… Group 3) (#7) - Add custom_message_type field to HookFilter struct - Implement extract_custom_message_type() for namespace detection - Update matches_filter() to check custom types against expected types - Add unit tests for custom type extraction and filtering (6 new tests) - Add integration test for E2E custom type routing - Fix clippy warnings in existing filter tests Phase 3 Task Group 3 complete. Hook system now supports filtering on all 12 custom XEP message types (thought, tool_call, tool_result, todo, code_change, integration, review_comment, work_available, question, answer, status_update, feature_complete) defined in Phase 3.1. Test Results: - 20 unit tests pass (chattermax-server) - 1 integration test passes - 15 chattermax-core tests pass - Zero compiler warnings - Clippy passes with -D warnings - Code formatted with cargo fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement custom message type filtering in the hook system to enable hooks to trigger on the 12 custom XEP message types defined in Phase 3.1.
This enables the hook system to discriminate between different structured message types (thought, tool_call, tool_result, todo, code_change, integration, review_comment, work_available, question, answer, status_update, feature_complete) and invoke appropriate handlers based on message type.
Changes
Test Results
Acceptance Criteria