Update TypeScript target to match NodeJS 12#70
Open
andrewiggins wants to merge 1 commit intotesting-library:mainfrom
Open
Update TypeScript target to match NodeJS 12#70andrewiggins wants to merge 1 commit intotesting-library:mainfrom
andrewiggins wants to merge 1 commit intotesting-library:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the package.json specifies that the min NodeJS version is 12, I've updated the TypeScript to target es2017. The only change this has in the output is that async/await is no longer downleveled and is left as-is since NodeJS 12 supports async/await natively 🎉
I came across this while debugging locally in my node_modules and not having to jump through TypeScript's
__awaiterhelper would make this easier, at least for users like me 😅