Skip to content

refactor: renaming note field to comment field#14

Open
alvaropaco wants to merge 36 commits intotetherto:devfrom
alvaropaco:main
Open

refactor: renaming note field to comment field#14
alvaropaco wants to merge 36 commits intotetherto:devfrom
alvaropaco:main

Conversation

@alvaropaco
Copy link
Contributor

@alvaropaco alvaropaco commented Dec 18, 2025 •
edited
Loading

The terminology update from "Note Field" to "Comment Field" has been completed across all three platform applications and the shared vault library. Here's a summary of all the changes made:

Changes

  • InputFieldNote/index.js - Updated label from "Note" to "Comment" and placeholder from "Add note" to "Add comment"
  • CreateOrEditLoginModalContent - Updated schema, initialValues, onSubmit data, and UI
  • CreateOrEditIdentityModalContent - Updated schema, initialValues, onSubmit data, and UI
  • CreateOrEditCreditCardModalContent - Updated schema, initialValues, onSubmit data, and UI
  • CreateOrEditWifiModalContent - Updated schema, initialValues, onSubmit data, and UI
  • CreateOrEditPassPhraseModalContent - Updated schema, initialValues, onSubmit data, and UI
  • Test file and snapshot updated

Dependencies

@alvaropaco alvaropaco self-assigned this Dec 18, 2025
@alvaropaco alvaropaco changed the base branch from main to dev December 18, 2025 14:04
@giorgikh93 giorgikh93 requested a review from torkinos December 22, 2025 07:00
@giorgikh93
Copy link
Contributor

giorgikh93 commented Dec 22, 2025

When dependent PR - tetherto/pearpass-lib-vault#3 is merged to tether/main it's important to include the commit (so the latest commit) from the pearpass-lib-vault tether/main branch in this work - the idea is that, pearpass-app-desktop should include the latest commit of its submodules. lmk if you have questions on this, thanks.

@torkinos
Copy link
Contributor

torkinos commented Jan 5, 2026

I’d suggest keeping these PRs in draft until tetherto/pearpass-lib-vault#3 is merged.

Also, after this change is applied we should probably update CreateOrEditCustomModalContent component as well

torkinos and others added 11 commits January 8, 2026 18:58
@torkinos
Include staging branch for CI/CD processes
2253db5
@torkinos
1.2.0
7065d80
@alvaropaco @chetasr
@torkinos @giorgikh93 @ndolidzee @denislupookov @harrisaar-noxtton @shavtvalishvili @eugeneglova
DEV: Installer, Packaging, and Search Enhancements (tetherto#70)
53a7ffa 
* Add JIT and unsigned executable memory permissions (tetherto#65)

* feat: add flathub assets (tetherto#22)

* refactor: renaming note field to comment field

* feat: adding flatpack necessary assets

* Add write permissions for release job in build workflow

* revert: discarding comment filed changes

* fix: changing flatpack id in the project

---------

Co-authored-by: Chetas Murali <thephantomblu@gmail.com>
Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>

* update submodule to include generating password improvements (tetherto#66)

* feat: adding splash image to appling (tetherto#67)

* Add custom fields into search pattern (tetherto#68)

* General maintenance, security, and stability improvements (tetherto#63)

* Migrate leftover commits (tetherto#2)

* Update modules and migrate leftover commits (#1)

* update modules and migrate leftover commits

* update modules

* update modules

* Updated last onboarding screen (tetherto#8)

* Updated last onboarding screen

* remove image + updated formatting

* removed as component

* closed image tag

* formatting

* TypeScript build setup. (tetherto#4)

* TypeScript build setup.

* Configure linting on pre-commit/CI and tests on CI (tetherto#3)

* Fix merge-main workflow (tetherto#12)

* Fix merge-main workflow

* Add data-test ids (tetherto#15)

* Add data-test ids

* Fix failing tests

* PAD-6: Update pairing UI flow (tetherto#16)

* PAD-6: Update pairing UI flow

* add type for clipboard event

* Added restriction on workflow to run only on noxtton side (tetherto#19)

* leftover commits

---------

Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>
Co-authored-by: Denis Lupookov <36776703+denislupookov@users.noreply.github.com>
Co-authored-by: Harri Saar Noxtton <h.saar@noxtton.com>
Co-authored-by: Nikoloz Dolidze <n.dolidze@noxtton.com>

* update submodules and add type (tetherto#5)

* Add test ids (tetherto#8)

* update pearpass-lib-data-import to latest commit (tetherto#9)

* Remove lint/test workflows to merge with tether (tetherto#4)

* Add PAT_TOKEN for test/lint workflows on tether side

* update token

* update token

* remove lint/test workflow

* Added lint/test workflows (tetherto#11)

* Added lint/test workflows

* Update modules

* workflow imrovements

* TS hot reload update for submodules. (tetherto#12)

* Password secure handling (tetherto#18)

* Convert passwords to buffers with explicit memory clearing.

* Add linting changes,

* security improvements

* Restrict updating same password as old (tetherto#19)

* PAD-262: Restrict setting the old password.

* PAD-262: Destructure parameters, use useTranslation hook.

* PAD-262: Update validatePasswordChange usage.

* PAD-262: Resolve lint issue.

* PAD-262: Update i18n mock to handle interpolation, update package lock.

* Add write permissions for release job in build workflow (tetherto#48)

* Improve global and folder search

* Improve blind peers settings clarity (tetherto#47)

* Improve blind peers settings clarity

* remove style changes for button

* Update src/pages/SettingsView/SettingsAdvancedTab/SettingsBlindPeersSection/index.js

Co-authored-by: Eugene Glova <eugene.glova@gmail.com>

---------

Co-authored-by: Eugene Glova <eugene.glova@gmail.com>

---------

Co-authored-by: Giorgi Shavtvalishvili <gshavtvalishvili@gmail.com>
Co-authored-by: Nikoloz Dolidze <n.dolidze@noxtton.com>
Co-authored-by: Denis Lupookov <36776703+denislupookov@users.noreply.github.com>
Co-authored-by: Eugene Glova <eugene.glova@gmail.com>

* Pad 284 vault selector (tetherto#17)

* PAD-284: Resolve missing export.

* PAD-284: Update the vault selector and add vault creation button, add a new design for vault creation.

* PAD-284: Display lock icon on protected vaults, make vault dropdown items scrollable.

* PAD-284: Add typing via typescript, add minor simplifications.

* PAD-284: Resolve design inconsistencies.

* convert files to ts

---------

Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>

* fix compiling issue

* Update modules

* Refactor fix test cases, adjust error handling and extend types (tetherto#21)

* Refactor fix test cases in usePearUpdate, adjust error handlingand extend types

* update package-lock

---------

Co-authored-by: Denis Lupookov <denislupookov@gmail.com>

* Auto lock configuration page (tetherto#23)

* Add auto lock configuration

* Minor refactor

---------

Co-authored-by: ndolidze <n.dolidze@noxtton.com>

* Add type declaration

* Add type declaration

* Update type declaration

* Pad 284 vault selector (tetherto#22)

* PAD-284: Resolve missing export.

* PAD-284: Update the vault selector and add vault creation button, add a new design for vault creation.

* PAD-284: Display lock icon on protected vaults, make vault dropdown items scrollable.

* PAD-284: Add typing via typescript, add minor simplifications.

* PAD-284: Resolve design inconsistencies.

* convert files to ts

* PAD-284: Pass isOpen and delayMs to CreateVaultButton.

---------

Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>

* Update submodules

* Pad 269 improve folder structure (tetherto#16)

* PAD-269: Update folder structure.

* PAD-269: Resolve snapshot issues.

* PAD-269: Destructure folder objects, use useTranslation.

* PAD-269: Introduce missing folder add functionality, remove dead code.

* PAD-269: Pass selected folder to records created from EmptyCollectionView.

* PAD-269: Ignore pear changes on dev, update tests and snapshots.

* PAD-269: Add automatic favorite selection.

---------

Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>

* Update submodules

* Imprive formatting and package.json to include additional files

---------

Co-authored-by: Giorgi Khatiashvili <57389796+giorgikh93@users.noreply.github.com>
Co-authored-by: Denis Lupookov <36776703+denislupookov@users.noreply.github.com>
Co-authored-by: Harri Saar Noxtton <h.saar@noxtton.com>
Co-authored-by: Nikoloz Dolidze <n.dolidze@noxtton.com>
Co-authored-by: Giorgi Shavtvalishvili <62855811+shavtvalishvili@users.noreply.github.com>
Co-authored-by: Giorgi Shavtvalishvili <gshavtvalishvili@gmail.com>
Co-authored-by: Eugene Glova <eugene.glova@gmail.com>
Co-authored-by: Denis Lupookov <denislupookov@gmail.com>

* fix: PearPass installer logo adjustments (tetherto#71)

* feat: adding splash image to appling

* fix: appling installer logo adjustments

* Updating Pear logo dimensions

---------

Co-authored-by: Chetas Murali <thephantomblu@gmail.com>
Co-authored-by: Tornike Kapanadze <tornikekapan@gmail.com>
Co-authored-by: Giorgi Khatiashvili <57389796+giorgikh93@users.noreply.github.com>
Co-authored-by: Nikoloz Dolidze <n.dolidze@noxtton.com>
Co-authored-by: Denis Lupookov <36776703+denislupookov@users.noreply.github.com>
Co-authored-by: Harri Saar Noxtton <h.saar@noxtton.com>
Co-authored-by: Giorgi Shavtvalishvili <62855811+shavtvalishvili@users.noreply.github.com>
Co-authored-by: Giorgi Shavtvalishvili <gshavtvalishvili@gmail.com>
Co-authored-by: Eugene Glova <eugene.glova@gmail.com>
Co-authored-by: Denis Lupookov <denislupookov@gmail.com>
@torkinos
Merge branch 'dev' into staging
1c4b1cc
@torkinos
Merge pull request tetherto#72 from tetherto/staging
db2815b
@torkinos
Adjust id generation for vaults
e728789
@torkinos
Update dependencies
d480e68
@torkinos
Update dependencies
a422426
@torkinos
Update dependencies
2046ac9
@torkinos
Update workflow
13d937b
@torkinos
Update workflow
f68ee1a
denislupookov and others added 12 commits January 27, 2026 19:08
@denislupookov
Added never option and removed toggle for auto lock feature (tetherto…
2c4d66c 
…#110)

* Updated default value for auto lock to 30 seconds

* Add support of never and removed toggle

* small refactor
@denislupookov @torkinos
Added never option and removed toggle for auto lock feature (tetherto…
ab25127 
…#110)

* Updated default value for auto lock to 30 seconds

* Add support of never and removed toggle

* small refactor
@torkinos @denislupookov
Update auto lock configuration (tetherto#111)
defb799 
* Added never option and removed toggle for auto lock feature (tetherto#110)

* Updated default value for auto lock to 30 seconds

* Add support of never and removed toggle

* small refactor

* Update auto lock descryption

---------

Co-authored-by: Denis Lupookov <36776703+denislupookov@users.noreply.github.com>
@denislupookov @torkinos
Update records to save the passkeys (tetherto#114)
e11c1eb 
* Update records to save the passkeys

* update pearpass-lib-vault

* refactor
@torkinos
Update modules
5209c5c
@chetasr
remove files from stage (tetherto#124)
eaa9fd3
@chetasr
rollback to prod (tetherto#125)
8f4f143
@chetasr
Merge pull request tetherto#107 from tetherto/staging
8b67c6e 
Release v1.3.0
@chetasr
fix branch
99f711d
@chetasr
remove tetherto check
aa4759f
@chetasr
undo check removal
eba0fc2
@moromisato
Merge pull request tetherto#128 from chetasr/main
0c96cc9 
fix appling generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torkinos torkinos Awaiting requested review from torkinos

At least 1 approving review is required to merge this pull request.

Assignees

@alvaropaco alvaropaco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@alvaropaco @giorgikh93 @torkinos @chetasr @ndolidzee @shavtvalishvili @denislupookov @moromisato