docs(evm): fix config examples and api ref#74
Open
ihsraham wants to merge 2 commits intotetherto:developfrom
Open
docs(evm): fix config examples and api ref#74ihsraham wants to merge 2 commits intotetherto:developfrom
ihsraham wants to merge 2 commits intotetherto:developfrom
Conversation
- Replace incorrect Ethers.js provider example with Viem in configuration.md - Remove internal fees constants from api-reference.md - Update usage.md (user edits) Task: https://app.asana.com/1/45238840754660/project/1210603136530746/task/1212799451446492
…ix/evm-wallet-audit
| console.log('Seed phrase:', seedPhrase) | ||
|
|
||
| {% hint style="danger" %} | ||
| **Secure the Seed Phrase:** You must securely store this seed phrase immediately. If it is lost, the user will permanently lose access to their funds. |
There was a problem hiding this comment.
Suggested change
| **Secure the Seed Phrase:** You must securely store this seed phrase immediately. If it is lost, the user will permanently lose access to their funds. | |
| **Secure the Seed Phrase:** You must securely store this seed phrase immediately. If you lose it, you will be unable to unlock the wallet and access its funds. |
Active voice when possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses inaccuracies in the EVM Wallet documentation identified during verification.
Changes
JsonRpcProvider(Ethers v6) example with a workingviemcreatePublicClientexample. The previous example caused runtime errors due to missing EIP-1193 compliance.FEE_RATE_NORMAL_MULTIPLIER,FEE_RATE_FAST_MULTIPLIER). These are protected static properties and are not exposed in the public API.usage.md: Included user-provided edits to align with the latest findings.Related Task
Asana Task: EVM Standard Audit
Verification
viemconfiguration example matches the library's usage patterns.