docs(solana): fix types and account instantiation pattern#77
Open
ihsraham wants to merge 1 commit intotetherto:developfrom
Open
docs(solana): fix types and account instantiation pattern#77ihsraham wants to merge 1 commit intotetherto:developfrom
ihsraham wants to merge 1 commit intotetherto:developfrom
Conversation
- Replace direct WalletAccountSolana constructor with getAccount() pattern - Fix return types: number → bigint for balances and fees - Correct result.hash references (SDK uses hash, not signature) - Use valid BIP-39 test mnemonic in Quick Start example Verified: 13/13 API tests passed, all blind copy-paste tests passed
|
|
||
| // Use a BIP-39 seed phrase (replace with your own secure phrase) | ||
| const seedPhrase = 'your twelve word seed phrase here' // Replace with actual seed generation | ||
| const seedPhrase = 'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about' |
There was a problem hiding this comment.
out of curiosity, why abandon* about?
Contributor
Author
There was a problem hiding this comment.
So it's more like Lorem Ipsum. Abandon is at index zero of BIP39 english wordlist. And the last word has to be index 3(about) to keep checksum valid (checksum of all other being at index 0)
So it's like the simplest 12 word mnemonic
lucas-tortora
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes documentation inaccuracies found during verification against actual SDK TypeScript types.
Files Changed
1. sdk/wallet-modules/wallet-solana/configuration.md
Issue: Direct
WalletAccountSolanaconstructor example fails at runtime.Fix: Replace with
WalletManagerSolana.getAccount()pattern.2. sdk/wallet-modules/wallet-solana/api-reference.md
Issue: Return types documented as
numberbut SDK returnsbigint.Fix: Update all method signatures to use correct types.
getFeeRates(){normal: number, fast: number}{normal: bigint, fast: bigint}getBalance()Promise<number>Promise<bigint>getTokenBalance()Promise<number>Promise<bigint>sendTransaction(){hash: string, fee: number}{hash: string, fee: bigint}transfer(){hash: string, fee: number}{hash: string, fee: bigint}quoteSendTransaction(){fee: number}{fee: bigint}quoteTransfer(){fee: number}{fee: bigint}3. sdk/wallet-modules/wallet-solana/usage.md
Issue 1: Code examples used
result.signaturebut SDK returnsresult.hash.Issue 2: Quick Start used invalid placeholder seed phrase, fails when snippet copied and pasted.
Verification
Related Task
[WDK] Solana: Audit sdk/wallet-modules/wallet-solana/*