Skip to content

upgrade on matlab-demo-en.tm#2

Open
Matthias-A-Steiner wants to merge 9 commits intotexmacs:masterfrom
Matthias-A-Steiner:master
Open

upgrade on matlab-demo-en.tm#2
Matthias-A-Steiner wants to merge 9 commits intotexmacs:masterfrom
Matthias-A-Steiner:master

Conversation

@Matthias-A-Steiner
Copy link

I've fixed some inconsistencies and added some further clarifications
Tilda A. Steiner

Matthias-A-Steiner and others added 9 commits March 4, 2021 18:53
	geändert:       bin/tm_matlab
	umbenannt:      matlab-abstract.en.tm -> doc/matlab-abstract.en.tm
	umbenannt:      matlab-demo.en.tm -> doc/matlab-demo.en.tm
	umbenannt:      matlab-install.en.tm -> doc/matlab-install.en.tm
	geändert:       doc/matlab.en.tm
	gelöscht:       matlab.en.tm
	gelöscht:       tm_matlab
 	geändert:       doc/matlab-install.en.tm
 	geändert:       doc/matlab.en.tm
Copy link

@mgubi mgubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. @sadhen what do you think?

@mgubi mgubi requested a review from da-liii April 18, 2021 10:02
@da-liii
Copy link
Contributor

da-liii commented Apr 19, 2021

Look good to me too. @mgubi could you help commit it to SVN?

@da-liii
Copy link
Contributor

da-liii commented Apr 19, 2021

@Matthias-A-Steiner
Copy link
Author

Dear Darcy,
I noticed that my pull request has not been fully accepted yet. Is this because your are still waiting for s.th. from me?

Yours
Tilda A. Steiner

@mgubi
Copy link

mgubi commented May 2, 2021

I think @sadhen is waiting for me to commit it. Sorry for the delay. I will try to do it soon. I think the PR is complete.

@mgubi
Copy link

mgubi commented May 2, 2021

I see that now the branch has one conflict. @Matthias-A-Steiner can you resolve it? I will try to close this PR soon.

@Matthias-A-Steiner
Copy link
Author

Dear mgubi,
how do I resolve the conflict?

@mgubi
Copy link

mgubi commented May 2, 2021

I think it is enough to put your local repo in sync with texmacs/master to manifest there the conflict, resolve it, and then push to your remote branch Matthias-A-Steiner/matlab . This should automatically update the PR.

@Matthias-A-Steiner
Copy link
Author

Dear mgubi,
I'm a bit confused. The file doc/matlab-demo.en.tm has already been uploaded. Of course it conflicts with the previous upload as I added corrections and minor improvements. And how do I sync my local repo with the remote branch

@pireddag
Copy link

pireddag commented May 3, 2021

@Matthias-A-Steiner Please take a look at the Readme file of https://github.com/texmacs/notes, last few lines, on how to update your local branch.

The matlab-demo is marked as a conflict (by logic, I did not check) because it has been changed both in the repository and in the branch which you are making the pull request from.
It makes sense to take a look at the changes in the repository and see if you want to integrate any into your version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants