Open
Conversation
C-L-Grove
suggested changes
Jun 20, 2024
| return np.min(data, axis=0) | ||
|
|
||
|
|
||
| def s_dev(data): |
There was a problem hiding this comment.
Unclear function name, prefer something like standard_deviation
There was a problem hiding this comment.
Is the function necessary? Could you np.std to compute standard deviation
C-L-Grove
approved these changes
Jun 20, 2024
C-L-Grove
left a comment
C-L-Grove
left a comment
There was a problem hiding this comment.
Already includes tests for:
- Standard deviation for one patient with multiple observations.
- Standard deviation function should raise an error if given empty data.
- Function should work with numpy arrays
Suggestion for other tests:
4. Standard deviation for two patients.
5. Graph includes a standard deviation graph.
6. Computing standard deviation where deviation is different from variance.
7. Standard deviation function should give correct result given negative inputs.
Co-authored-by: C-L-Grove <callum.grove@ukaea.uk>
Co-authored-by: C-L-Grove <callum.grove@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the graphs to show the standard deviation as required by SR1.1.1