Conversation
reflectronic
left a comment
reflectronic
left a comment
There was a problem hiding this comment.
Is there an example of how this gets used on the app side?
| pngIcon.setOverlayIcon(overlayIcon); | ||
| pngIcon.setOverlayIconMac(overlayIconMac); | ||
|
|
||
| QSize size(256, 256); |
There was a problem hiding this comment.
We should generate all the right sizes and assets according to https://learn.microsoft.com/en-us/windows/apps/design/style/iconography/app-icon-construction. We also need to make sure that the sizing is correct
|
|
||
| QProcess makeappxProcess; | ||
| makeappxProcess.setProcessChannelMode(QProcess::ForwardedChannels); | ||
| makeappxProcess.start("makeappx", {"pack", "/d", deployFolder.destinationDir().absolutePath(), "/p", parser.value("appx-output")}); |
There was a problem hiding this comment.
We need to be able to make multi-architecture bundles too. Bonus if we can split the architecture-neutral files out as well
There was a problem hiding this comment.
I think we'll need to have some discussions about the multi-architecture bundles once support for cross compiling arm is complete
| set(APPX_EXECUTABLE_NAME ${APPX_EXECUTABLE_NAME}.exe) | ||
| set(APPX_ARCH x64) # TODO: Update | ||
| set(APPX_VERSION ${REPOVERSION_MAJOR}.${REPOVERSION_MINOR}.${REPOVERSION_REVISION}.0) | ||
| set(APPX_SDK_VERSION ${APPX_SDK_VERSION_MAJOR}.${APPX_SDK_VERSION_MINOR}.${APPX_SDK_VERSION_REVISION}.${APPX_SDK_VERSION_BUILD}) |
There was a problem hiding this comment.
What does setting these properties do?
There was a problem hiding this comment.
Allows you to substitute values in the appxmanifest.xml file
|
Check out the same branch in theBeat for an example of an implementation |
vicr123
force-pushed
the
features/winappx
branch
from
0b43c19 to
94573d0
Compare
2 participants
This PR adds support for automatically building an MSIX package which can be submitted to the Windows Store for distribution.