To realign with No-Intro's naming convention#1
Open
atylmo wants to merge 2 commits intothebezelproject:masterfrom
Open
To realign with No-Intro's naming convention#1atylmo wants to merge 2 commits intothebezelproject:masterfrom
atylmo wants to merge 2 commits intothebezelproject:masterfrom
Conversation
According to No-Intro's naming convention, "The" is capitalized because it's part of Sonic's name. This should fix some bezels not showing up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://datomatic.no-intro.org/stuff/The%20Official%20No-Intro%20Convention%20(20071030).pdf Sonic's name includes "The," so it should be capitalized because it's not an article. If I don't either change the ROM name or the bezel name the bezel doesn't show up.