Fix FastGAN build target to use correct source file#20
Open
ekg wants to merge 1 commit intothegenemyers:mainfrom
Open
Fix FastGAN build target to use correct source file#20ekg wants to merge 1 commit intothegenemyers:mainfrom
ekg wants to merge 1 commit intothegenemyers:mainfrom
Conversation
The FastGAN target was referencing FastGA.new.c which does not exist in the repository, causing the build to fail with "No rule to make target 'FastGA.new.c'". Changed the dependency and compilation command to use FastGA.c instead, which is the actual source file present in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FastGA.new.cfileFastGA.cinsteadProblem
The Makefile references
FastGA.new.cwhich does not exist in the repository, causing make to fail with:Solution
Updated the FastGAN target dependency and compilation command to use
FastGA.c, which is the actual source file present in the codebase.Test Plan
makemake installworks correctly