Open
Conversation
thelebdev
requested changes
Jul 12, 2022
Owner
thelebdev
left a comment
thelebdev
left a comment
There was a problem hiding this comment.
A couple of comments:
- It would be good practice to provide the accepted values when the user is running
/.installer.sh "<OS>". A better user experience is to let the user run./installer.sh, and after they run the script, the code would return "Which OS are you using? (MacOS, Windows) - Most of the logic for MacOS and Windows is similar, with a small variation for the copying mechanism. To implement the DRY principle, it would be better practice to combine the common logic in a single file, and the different logic would be part of an
if-elsestatement depending on the user's operating system. - Make sure to update the documentation of the files
- I like the cleanliness of your work. Highly appreciated
| ############# | ||
| # File name: run.sh | ||
| # Purpose: When executed, this will copy a complex password to the user's clipboard | ||
| # Created by: Christophe El-Khoury (thelebdev) |
Owner
There was a problem hiding this comment.
Change the Created by part of the documentation and the file name
Owner
|
Closes #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited everything, including the README.md file. The script, single command version, works properly for me on windows. Please make sure it works properly on mac too!