fix Int32 random method generation with passed range into it#27
Open
azakordonets wants to merge 2 commits intothellimist:masterfrom
Open
fix Int32 random method generation with passed range into it#27azakordonets wants to merge 2 commits intothellimist:masterfrom
azakordonets wants to merge 2 commits intothellimist:masterfrom
Conversation
Owner
|
I think this is a Swift 3 change. Could you add the necessary checks and tests as well? Thanks |
Author
|
Done |
thellimist
reviewed
Jan 8, 2018
| #if swift(>=3) | ||
| return random(range.lowerBound, range.upperBound) | ||
| #else | ||
| return random(range.lowerBound, range.upperBound - 1) |
Owner
There was a problem hiding this comment.
I'm assuming this is correct. Based on that, the parameters are reversed and -1 should go to swift 3 >=. I haven't tested it so my assumption might be wrong. I'd appreciate if you can confirm both Int and Int32 works.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upper bond cannot be less the lower bond. Added unit tests as well.