Open
Conversation
…local file operations do not work anyways
…ates, like mashable
Goose uses a HashSet for iterating topNode candidates But HashSet doesn't guarantee ordering, so when two candidates have the same score, the choice is basically random. This is not acceptable. Now, by using LinkedHashSet we make sure that in case of draw, we choose the first tag that was found in the DOM tree.
Using LinkedHashSet to avoid inconsistency
Accept cookies from web sites which put all the cookies into one request header.
Conflicts: build.sbt src/main/scala/com/gravity/goose/Configuration.scala
Conflicts: README.md build.sbt pom.xml src/main/scala/com/gravity/goose/Article.scala src/main/scala/com/gravity/goose/Configuration.scala src/main/scala/com/gravity/goose/opengraph/OpenGraphData.scala src/test/scala/com/gravity/goose/GooseTest.scala
Conflicts: pom.xml src/main/scala/com/gravity/goose/Article.scala src/main/scala/com/gravity/goose/Configuration.scala src/main/scala/com/gravity/goose/Crawler.scala src/main/scala/com/gravity/goose/images/ImageExtractor.scala src/main/scala/com/gravity/goose/images/StandardImageExtractor.scala src/main/scala/com/gravity/goose/images/UpgradedImageIExtractor.scala src/main/scala/com/gravity/goose/network/HtmlFetcher.scala src/test/scala/com/gravity/goose/TestUtils.scala src/test/scala/com/gravity/goose/TextExtractionsTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged various forks to include as many as possible improvements made to goose in the main trunk.