List now scrolls down, left and right on dpad interaction#1
Open
AyoTheDev wants to merge 4 commits intothesauri:mainfrom
Open
List now scrolls down, left and right on dpad interaction#1AyoTheDev wants to merge 4 commits intothesauri:mainfrom
AyoTheDev wants to merge 4 commits intothesauri:mainfrom
Conversation
Owner
|
Thanks for the contribution! Out-of-the-box support for this seems to have been added since when I initially wrote this. I tried your repository that includes a newer version of Compose, but reverted the changes to Screen.Recording.2022-01-23.at.12.38.05.movCould you verify this behavior and revert the changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across
BringIntoViewRequesterfrom this article:https://medium.com/tech-takeaways/automatic-scrolling-to-composable-on-focus-change-with-bringintoviewrequester-in-jetpack-compose-bdeb72242bac
I've integrated this into ScrollableGrid.
I've also added a KeyEventListener so that if we're on the first or last item in a row, the d-pad event is not propagated
If you have any thoughts/idea's that would be greatly appreciated